fix HCCL port conflict on multi-dp rank startup(single node)#4722
Open
wanfengcxz wants to merge 1 commit into
Open
fix HCCL port conflict on multi-dp rank startup(single node)#4722wanfengcxz wants to merge 1 commit into
wanfengcxz wants to merge 1 commit into
Conversation
jinminxi104
approved these changes
Jun 30, 2026
grimoire
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily receiving feedbacks. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
使用 Ascend NPU 启动 dp=2, tp=4 服务会报错:
分析:
attn_tp = world_size // dp = 4 // 2 = 2(每个 dp_rank 只有 2 个 workers)rank_offset = dp_rank * attn_tpdp_rank=0:rank_offset=0,workers 应使用逻辑设备 0, 1dp_rank=1:rank_offset=2,workers 应使用逻辑设备 2, 3Modification
在
ASCEND_RT_VISIBLE_DEVICES分支中加回self.rank_offset,与旧代码行为保持一致:对应旧代码(commit 之前,无 rank table 情况下):
BC-breaking (Optional)
Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist